Skip to content
  • Marek Vasut's avatar
    mkimage: Fix warning from fix for generating multi and script images again · 34633141
    Marek Vasut authored
    Seems 6ae6e160
    
     broke creating images in certain cases, there
    are two problems with that patch.
    
    First is that the expression "!x == 4 || !x == 6" is ambiguous.  The
    intention here was "!(x == 4) || !(x == 6)" based on reading further in
    the file, where this was borrowed from.  This however is interpreted by
    gcc as "(!x) == 4 || (!x) == 6" and always false.  gcc-5.x will warn
    about this case.
    
    The second problem is that we do not want to test for the case of "(NOT x
    is 4) OR (NOT x is 6)" but instead "(x is not equal to 4) AND (x is not
    equal to 6)".  This is because in those two cases we already execute the
    code question in another part of the file.  Rewrite the expression and
    add parenthesis for clarity.
    
    Signed-off-by: default avatarMarek Vasut <marex@denx.de>
    Cc: Tom Rini <trini@konsulko.com>
    Cc: Philippe De Swert <philippedeswert@gmail.com>
    Cc: Simon Glass <sjg@chromium.org>
    [trini: Re-word Marek's explanation]
    34633141