Commit 3f2f08fe authored by Otavio Salvador's avatar Otavio Salvador

fsl-default-providers.inc: Make virtual/kernel assigment delayed

In 01851da (machine/*: Allow kernel provider override) the assigment
of preferred provider for virtual/kernel has been changed to a weak
assignment. This works for most of cases but has caused a regression
in some machines.

When a machine includes the imx-base.inc file, the assignment is done
and the intended setting of the machine does not take effect.

For example, in the below code fragment:

,----[ Wandboard board configuration fragment  ]
| include conf/machine/include/imx-base.inc
| ...
| PREFERRED_PROVIDER_virtual/kernel ?= "linux-wandboard"
`----

the virtual/kernel provider would be 'linux-imx' as, at the time of
imx-base.inc inclusion, it was undefined. The expected behaviour would
be to use 'linux-imx' /only/ when no setting has been done.

The ??= operator solves this as it is used /only/ if no assignment is
done to the virtual/kernel provider in the end of the parsing. So it
gives the expected behaviour.

Change-Id: Iab73dcff8bef7f2df1064a0d5d04fd506a4c3144
Reported-by: 's avatarAlfonso Tamés <alfonso@mantic.mx>
Signed-off-by: 's avatarOtavio Salvador <otavio@ossystems.com.br>
parent 31aef9be
# Freescale BSP default providers
PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
PREFERRED_PROVIDER_virtual/kernel ?= "linux-imx"
PREFERRED_PROVIDER_virtual/kernel ??= "linux-imx"
PREFERRED_PROVIDER_u-boot ?= "u-boot-fslc"
PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment